Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Broken layout on new project with --skip-webpack #784

Closed
stanislas-m opened this issue Dec 5, 2017 · 1 comment
Closed

Broken layout on new project with --skip-webpack #784

stanislas-m opened this issue Dec 5, 2017 · 1 comment
Labels
bug Something isn't working
Milestone
0.10.3

Comments

@stanislas-m
Copy link
Member

stanislas-m commented Dec 5, 2017 •
edited
Loading

Setup

  • Buffalo 0.10.2
  • Ubuntu GNU/Linux (applicable to Windows & MacOSX)

Steps to reproduce

  • Create a new project with buffalo, using the --skip-webpack option.
  • Start buffalo dev and open a browser to see the home page.

Expected behavior

The page has the same presentation as the webpack one.

Current behavior

The page layout is degraded, due to Bootstrap css link missing (in the webpack setup, bootstrap is embedded using sass).

Proposed fix

Use the WithWebpack opt to detect if webpack is not used, then add Bootstrap link to the template.

{{- if not .opts.WithWebpack }}
  <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">
{{- end }}
@stanislas-m stanislas-m added the bug Something isn't working label Dec 5, 2017
stanislas-m added a commit that referenced this issue Dec 5, 2017
@stanislas-m
Fix #784 Broken layout when using --skip-webpack
47747ee 
* Include Bootstrap link when --skip-webpack is used.
* Add missing DOCTYPE.
* Add a condition to show flashes markup only when there are flashes.
markbates added a commit that referenced this issue Dec 6, 2017
@markbates
Merge pull request #785 from gobuffalo/fix-broken-layout-without-webpack
16ef257 
Fix #784 Broken layout when using --skip-webpack
@markbates markbates added this to the 0.10.3 milestone Dec 6, 2017
@paganotoni
Copy link
Member

paganotoni commented Dec 15, 2017 •
edited
Loading

Closing this given PR #785 was already merged and solves this bug

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.3
Development

No branches or pull requests
3 participants
@markbates @paganotoni @stanislas-m