Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Bugfix/multiple word auto #1002

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Conversation

paganotoni
Copy link
Member

Solves #1000

@paganotoni paganotoni changed the title Bugfix/multiple word auto WIP: Bugfix/multiple word auto Apr 3, 2018
@@ -91,7 +91,7 @@ func (htmlAutoRenderer) ContentType() string {
}

func (ir htmlAutoRenderer) Render(w io.Writer, data Data) error {
name := inflect.Name(strings.ToLower(ir.typeName()))
name := inflect.Name(inflect.Underscore(ir.typeName()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t inflect.Name.File() do what we want?

@paganotoni paganotoni changed the title WIP: Bugfix/multiple word auto Bugfix/multiple word auto Apr 3, 2018
@paganotoni
Copy link
Member Author

@markbates when you have the chance I just fixed my test and is passing now

@markbates markbates added this to the 0.11.1 milestone Apr 4, 2018
@markbates
Copy link
Member

@paganotoni looks good. feel free and merge once the tests all pass. thanks.

@paganotoni
Copy link
Member Author

thanks @markbates! so good to have issues assigned! do you have something else you want me to look into for v0.11.1 ?

@paganotoni paganotoni merged commit 1bf8c44 into development Apr 4, 2018
@paganotoni paganotoni deleted the bugfix/multiple-word-auto branch April 4, 2018 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants