This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Moving to use Webpack 4 #1007
Merged
Moving to use Webpack 4 #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislas-m
suggested changes
Apr 5, 2018
| ], | ||
| } | ||
|
|
||
| Glob.sync("./assets/*/*.*").reduce((_, entry) => { |
There was a problem hiding this comment.
If you use reduce here, you'll drop the first file, even if it's not application.scss. :)
|
@stanislas-m all set with that change. |
This was referenced Apr 6, 2018
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
* moving to use webpack4 * adding uglifier options on the right place * moving to use miniCSS as webpack recommends * disabling comments from production build js * adding back babel env as preset * removing transition * using forEach
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves new buffalo templates to use webpack 4.5 it also attempts to organize the JS code in generated webpack.config.js.
Props on this one to @stanislas-m for all the help and guidance!