Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

make vbuffalo opt-in for now #1096

Merged
merged 14 commits into from
Jun 11, 2018
Merged

make vbuffalo opt-in for now #1096

merged 14 commits into from
Jun 11, 2018

Conversation

markbates
Copy link
Member

No description provided.

@markbates markbates added this to the 0.12.0 milestone Jun 10, 2018
Makefile Outdated
@@ -0,0 +1,15 @@
TAGS="sqlite vbuffalo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a conditional assign here? This way, we provide a default, but the user can override the TAGS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanislas-m you're stretching my Makefile skills here. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_6.html:

There is another assignment operator for variables, `?='. This is called a conditional variable assignment operator, because it only has an effect if the variable is not yet defined. This statement:

FOO ?= bar

is exactly equivalent to this (see section The origin Function):

ifeq ($(origin FOO), undefined)
  FOO = bar
endif

Note that a variable set to an empty value is still defined, so `?=' will not set that variable. 

@stanislas-m
Copy link
Member

@markbates Did you put the GOPATH in the PATH? I think that's why packr is not found in the last builds.

@markbates markbates merged commit 4843312 into development Jun 11, 2018
@codecov
Copy link

codecov bot commented Jun 11, 2018

Codecov Report

Merging #1096 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1096   +/-   ##
============================================
  Coverage        60.76%   60.76%           
============================================
  Files               56       56           
  Lines             2867     2867           
============================================
  Hits              1742     1742           
  Misses            1022     1022           
  Partials           103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0798810...e1981e2. Read the comment docs.

@markbates markbates deleted the vbuffalo-opt-in branch June 11, 2018 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants