Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Add codecov.io badge #1100

Merged
merged 4 commits into from
Jun 12, 2018
Merged

Add codecov.io badge #1100

merged 4 commits into from
Jun 12, 2018

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Jun 12, 2018

There is no coverage information for master branch yet, that's why badge says "unknown" for now.

.codecov.yml format is documented here. See also next pages; specifically, here for what "range" means.

@AlekSi
Copy link
Contributor Author

AlekSi commented Jun 12, 2018

btw, @markbates, you can add --squash to docker build for gobuffalo/buffalo:development image to make it significantly smaller.

@markbates
Copy link
Member

@AlekSi if you know how to do that on hub.docker.com please let me know. That's where we build the images.

@AlekSi
Copy link
Contributor Author

AlekSi commented Jun 12, 2018

Looks like it is not possible: docker/hub-feedback#955 One workaround is to use multi-stage builds which are supported. Another one is to rebuild this image somewhere else.

@markbates
Copy link
Member

@AlekSi feel free and take a crack at making it smaller.

@markbates markbates merged commit 3c1337c into gobuffalo:development Jun 12, 2018
@markbates markbates added this to the 0.12.0 milestone Jun 12, 2018
@AlekSi AlekSi deleted the codecov-badge branch June 12, 2018 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants