This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Only save Session once to avoid duplicate session cookie #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash persist from Session save
saurori
commented
Dec 17, 2021
| @@ -103,7 +103,6 @@ func (ri RouteInfo) ServeHTTP(res http.ResponseWriter, req *http.Request) { | |||
|
|
|||
| events.EmitPayload(EvtRouteStarted, payload) | |||
| err := a.Middleware.handler(ri)(c) | |||
| c.Flash().persist(c.Session()) | |||
There was a problem hiding this comment.
It was not clear why this is needed, so I removed it. persist() no longer saves Session, so is this needed? Only reference is: #2054
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Commenting to remove stale. Still relevant, waiting for review 😢 |
fasmat
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this Issue: #2112
Session().Save()was being called multiple times. If the session data changes between calls toSave(), the session cookie value would be different and therefore set multiple times.Session().Save()was also called in flashpersist()and was therefore coupled tightly to Flash functionality.Session saving is now done only once in
Render()orRedirect(). There is still the possibility of a user callingc.Session().Save()in a request handler or similar and cause a duplicate session cookie to write.