This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Simplify i18n #763
Merged
Simplify i18n #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the `t` helper for every case (no more `tp`). - Load languages & translator function in the middleware, so the Translate function can be used inline; even in Go code. - Get closer to the i18n function interface, by forwarding variadic arg (plush already fixed for that). - Use the user data as context values, not Buffalo context (not precise enough in a loop, for instance).
stanislas-m
added
breaking change
|
I think these tests are failing because the docker image doesn't have the latest version of Plush on it. I just kicked off a rebuild of the image on docker hub. Once that's done you can retry the tests. |
|
Other than the tests, things look good, so I'll happily merge once the tests are passing. |
|
@markbates Seems good now! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thelper for every case (no moretp).This introduces a breaking change, because the
tphelper is removed, and the i18n helpers return only a string now.