Minor Refactorings #793
Minor Refactorings #793
Conversation
mail/smtp_sender.go
Outdated
| @@ -10,31 +10,51 @@ import ( | |||
|
|
|||
| //SMTPSender allows to send Emails by connecting to a SMTP server. | |||
| type SMTPSender struct { | |||
| Dialer *gomail.Dialer | |||
| Dialer *gomail.Dialer | |||
| message *gomail.Message | |||
There was a problem hiding this comment.
No sure this is a good idea to have the message here. How do you handle two concurrent Send?
|
@stanislas-m thanks the heads up, you're right! we better keep it as it was, that is, one |
buffalo/cmd/info.go
Outdated
| func execIfExists(name string, pathName string, c *exec.Cmd) { | ||
| bb := os.Stdout | ||
|
|
||
| if _, err := exec.LookPath("mysql"); err != nil { |
There was a problem hiding this comment.
mysql is hard coded here, which I'm assuming is not right.
buffalo/cmd/info.go
Outdated
|
|
||
| return nil | ||
| }, | ||
| func execIfExists(name string, pathName string, c *exec.Cmd) { |
There was a problem hiding this comment.
You can clean up this function by passing in the infoCommand struct instead of all these args.
buffalo/cmd/info.go
Outdated
| } else { | ||
| bb.WriteString("dep Not Found\n") | ||
| } | ||
| bb.WriteString("\n### Go Version\n") |
There was a problem hiding this comment.
Why not make this part of the bigger loop below?
buffalo/cmd/info.go
Outdated
| } else { | ||
| bb.WriteString("dep Not Found\n") | ||
| } | ||
| bb.WriteString("\n### Go Env\n") |
There was a problem hiding this comment.
Why not make this part of the bigger loop below?
|
@markbates All set on this one |
|
The only issue I've found with this is when I ran it against a project that didn't have |
|
🤔 I just tried it with a newly created buffalo app (without |
No description provided.