Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Fix broken URL in SHOULDERS.md #961

Merged
merged 2 commits into from
Mar 11, 2018
Merged

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Mar 10, 2018

No description provided.

@markbates markbates changed the base branch from master to development March 11, 2018 16:36
@markbates markbates added this to the 0.11.1 milestone Mar 11, 2018
@markbates
Copy link
Member

I'm merging this, because I want you to get contributor credit, but that file is actually auto generated by https://github.com/gobuffalo/buffalo/blob/master/grifts/shoulders.go, which is run when a new release is cut, so any changes to the SHOULDERS.md that are manually made will get wiped out. I would love a PR that fixed this automatically, if you're interested. :)

@markbates markbates merged commit 309ae27 into gobuffalo:development Mar 11, 2018
@ruudk
Copy link
Contributor Author

ruudk commented Mar 11, 2018

I see the issue now, it's impossible to fix.

Only solution I see is this: When url is from github.com then split url and insert /tree/master/ between path 2 and 3 for the URL. Not sure what you think about it?

But then I think it would be better to just change the URL to always point to https://godoc.org/xxx instead.

@ruudk ruudk deleted the patch-1 branch March 11, 2018 18:21
@markbates
Copy link
Member

I love the godoc idea! That’s brilliant. Let’s do that!

@ruudk
Copy link
Contributor Author

ruudk commented Mar 11, 2018

Cool, created PR in #964

stanislas-m pushed a commit that referenced this pull request May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants