This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Added http:// to server address in log to make it clickable #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
suggested changes
Mar 26, 2018
|
|
markbates
approved these changes
Mar 26, 2018
|
Brilliant. Thanks! |
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
* Added http:// to server address to make it clickable * Updated previous change to use Options.Host which provides formatted URL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: After starting a server, it would be nice to be able to click the server address in the console to open a browser. Adding http:// before the address in the current log output will make it clickable in some IDE's, and easier to copy & paste in others.
This is an edit to a line of logs, so it could be considered a content or documentation change. I'm not sure there is an easily accessible way to write unit tests.