Fix Api page layout #419
Closed
Fix Api page layout #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR :) I didn't notice this was broken again, I tried to fix it with gobuffalo/plush#77 and #405. I just had a look at this, it appears that the plush version hadn't been increased yet and 5784e79 reverted it back to an older version. If there's no visual difference introducing by removing the divs, we can still merge this pr, but it doesn't adress the true problem. |
|
Hi @lukasschlueter, I see what intentionality is. New template
If you think it's proper, I can commit changes :) |
Merged
|
Closed in favor of #422. I think the current side-by-side comparison is good this way. I would prefer it over tabs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api page
Previous template
New template