fix parsing of invalid map key (#520)

goccy · Nov 11, 2024 · 7e833a2 · 7e833a2
1 parent 8f36c1b
commit 7e833a2
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/parser/parser.go b/parser/parser.go
@@ -899,6 +899,8 @@ func (p *parser) createNodeFromToken(ctx *context, tk *token.Token) (ast.Node, e
 		return p.parseTag(ctx)
 	case token.LiteralType, token.FoldedType:
 		return p.parseLiteral(ctx)
+	case token.MappingValueType:
+		return nil, errors.ErrSyntax("found an invalid key for this map", tk)
 	}
 	return nil, nil
 }

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -1224,6 +1224,22 @@ a:
 			"key: [`val]",
 			"\n[1:7] found invalid token\n>  1 | key: [`val]\n             ^\n",
 		},
+		{
+			`{a: b}: v`,
+			`
+[1:7] found an invalid key for this map
+>  1 | {a: b}: v
+             ^
+`,
+		},
+		{
+			`[a]: v`,
+			`
+[1:4] found an invalid key for this map
+>  1 | [a]: v
+          ^
+`,
+		},
 	}
 	for _, test := range tests {
 		t.Run(test.source, func(t *testing.T) {