Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large hex strings are unquoted when marshalled #586

Closed
mcdee opened this issue Dec 10, 2024 · 1 comment · Fixed by #593
Closed

Large hex strings are unquoted when marshalled #586

mcdee opened this issue Dec 10, 2024 · 1 comment · Fixed by #593
Assignees
@shuheiktgw
Labels
bug Something isn't working encoder

Comments

@mcdee
Copy link

mcdee commented Dec 10, 2024

Describe the bug

Large hex strings are being encoded without quotes, and small hex strings are being encoded with quotes.

To Reproduce

https://go.dev/play/p/U1vXmvyBhLt

Expected behavior

Hex strings should remain quoted regardless of length.

Version Variables

  • Go version: 1.23.2
  • go-yaml's Version: 1.15.8
@mcdee mcdee added the bug Something isn't working label Dec 10, 2024
@goccy goccy added the encoder label Dec 11, 2024
@shuheiktgw shuheiktgw self-assigned this Dec 15, 2024
shuheiktgw added a commit that referenced this issue Dec 15, 2024
@shuheiktgw
Quote the numbers even if they are out of range
b5d5b31 
#586
@shuheiktgw shuheiktgw mentioned this issue Dec 15, 2024
Merged
2 tasks
goccy pushed a commit that referenced this issue Dec 16, 2024
@shuheiktgw
Quote the numbers even if they are out of range (#593)
61bc6c1 
* Quote the numbers even if they are out of range

#586

* Keep the original interface of the ToNumber function
@goccy
Copy link
Owner

goccy commented Dec 18, 2024

@mcdee Thank you for your reports ! We've fixed this problem with latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuheiktgw shuheiktgw

Labels
bug Something isn't working encoder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quote the numbers even if they are out of range goccy/go-yaml
3 participants
@goccy @mcdee @shuheiktgw