Fix "null" string encoded as nil #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 78.78% 78.79% +0.01%
==========================================
Files 13 13
Lines 4007 4009 +2
==========================================
+ Hits 3157 3159 +2
Misses 591 591
Partials 259 259 |
|
@goccy can you review this pr please? |
|
Thank you for your contribution ! LGTM 👍 |
jandubois
added a commit
to jandubois/lima
that referenced
this pull request
Nov 1, 2024
We used a custom marshaller to properly marshal "~" and "null". This has been fixed in goccy/go-yaml#474, which has been merged in lima-vm#2828. Dropping the custom marshaller fixes lima-vm#2665. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
subpop
pushed a commit
to subpop/lima
that referenced
this pull request
Dec 4, 2024
We used a custom marshaller to properly marshal "~" and "null". This has been fixed in goccy/go-yaml#474, which has been merged in lima-vm#2828. Dropping the custom marshaller fixes lima-vm#2665. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixing this open issue: #413
Solution: incorporate each keyword from reservedNullKeywords into reservedEncKeywordMap to indicate that null keywords should be enclosed in quotes. This ensures that only Golang's nil is represented as YAML null.
Currently, any string from reservedNullKeywords is being encoded as YAML null, which is not the intended behavior and may cause confusion. Because users use Golang's nil if they want YAML null and for some reason "null" string if they want string in yaml document
This fix reverts the some behavior that was erroneously changed in this this commit. Prior to this commit, only Golang's nil was represented as YAML null.