Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificates: New sharing button creates confusing user experience when button is next to the "Save" button #1379

Open
thomasplevy opened this issue Oct 14, 2020 · 1 comment · Fixed by #1387
Open

Certificates: New sharing button creates confusing user experience when button is next to the "Save" button #1379

thomasplevy opened this issue Oct 14, 2020 · 1 comment · Fixed by #1387
Labels
good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! help wanted Looking for contributors to assist with this issue Status: Has PR This issue has an open pull request Type: Enhancement Improvements existing features or code
Milestone
Future

Comments

@thomasplevy
Copy link
Contributor

Reproduction Steps

  • View an earned certificate as a student
  • Click "Enable Sharing" to allow a certificate to be shared

Expected Behavior

  • Users are expecting that a link will be provided to them which they can use to share the certificate
  • Some users expect that they must also "Save" the certificate (using the "Save" button) after enabling/disabling sharing

Actual Behavior

  • Clicking "save" is not necessary (as this is actually an export button)
  • There is no user feedback indicating what URL should be used to "Share" the certificate after sharing is enabled.

Proposal

  • The language of the "Save" button should be changed to "Download" or "Export"
  • When sharing is enabled, a readonly text input should be output with the certificate's URL populated in it. This will help users identify what URL should be used to share the certificate.
@thomasplevy thomasplevy added Type: Enhancement Improvements existing features or code help wanted Looking for contributors to assist with this issue good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! labels Oct 14, 2020
@thomasplevy thomasplevy added this to the Future milestone Oct 14, 2020
imknight added a commit to imknight/lifterlms that referenced this issue Oct 16, 2020
@imknight
change save to download and display cert permalink for gocodebox#1379
105d8b6
@eri-trabiccolo eri-trabiccolo added the Status: Has PR This issue has an open pull request label Oct 19, 2020
@imknight imknight mentioned this issue Oct 19, 2020
Merged
2 tasks
@thomasplevy thomasplevy mentioned this issue Oct 20, 2020
Merged
@thomasplevy
Copy link
Contributor Author

This was incorrectly referenced in a commit and has not yet been resolved.

@thomasplevy thomasplevy reopened this Nov 6, 2020
@thomasplevy thomasplevy mentioned this issue Nov 6, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! help wanted Looking for contributors to assist with this issue Status: Has PR This issue has an open pull request Type: Enhancement Improvements existing features or code
Projects
Development
Status: Approved
Milestone
Future
Development

Successfully merging a pull request may close this issue.

UX Improvements to shareable certificates imknight/lifterlms
2 participants
@thomasplevy @eri-trabiccolo