Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid JS error in the webui popover script #2680

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Avoid JS error in the webui popover script #2680

merged 3 commits into from
Jul 4, 2024

Conversation

brianhogg
Copy link
Contributor

Description

Checks that LLMS.l10n.translate is defined, otherwise use a default 'Close' aria label.

Fixes #2678

How has this been tested?

Manually

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg added this to the Next Available Release milestone Jun 18, 2024
@brianhogg brianhogg requested a review from ideadude as a code owner June 18, 2024 12:13
@ideadude ideadude merged commit 0056e53 into dev Jul 4, 2024
31 checks passed
@ideadude ideadude deleted the fix/2678-js-error branch July 4, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants