Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make the resources recommender histogram adjustable #698

Closed
zxh326 opened this issue Feb 21, 2023 · 4 comments
Closed

Can we make the resources recommender histogram adjustable #698

zxh326 opened this issue Feb 21, 2023 · 4 comments
Assignees
Labels

Comments

@zxh326
Copy link

zxh326 commented Feb 21, 2023

Describe the feature

Is it possible to make the current configuration adjustable instead of being fixed, as it results in the recommended resources, for example in the case of CPU, being at a minimum of "0.1 core"?

Histogram: predictionapi.HistogramConfig{
HalfLife: "24h",
BucketSize: "0.1",
MaxValue: "100",
},

@qmhu qmhu added good first issue Good for newcomers help wanted Extra attention is needed area:recommendation labels Feb 21, 2023
@github-actions
Copy link
Contributor

Hello @zxh326.
We totally like your proposal/feedback, welcome to send us a Pull Request for it.
Please send your Pull Request to main branch, fill the Pull Request Template here, provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon.
We appreciate your effort in advance and looking forward to your contribution!

你好 @zxh326,我们完全同意你的提议/反馈。
欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。
请将 Pull Request 发到 main 分支,务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、测试用例、文档等,并确保 CI 通过。
我们会尽快进行 Review,提前感谢和期待您的贡献。

@qmhu
Copy link
Member

qmhu commented Feb 21, 2023

This configuration can be exported with recommendation configuration. Anyone who want to contribute it could take it.

@comqx
Copy link

comqx commented Feb 21, 2023

Enjoy it !!!!!

@qmhu
Copy link
Member

qmhu commented Feb 23, 2023

Thank you for contribution!

@qmhu qmhu closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants