fix: add recommended resource allocation #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:recommendation
deploy
documentation
comqx
changed the title
|
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-699-61beeee \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-699-61beeee \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-699-61beeee \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-699-61beeee crane/craneCoding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-699-61beeee \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-699-61beeee \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-699-61beeee \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-699-61beeee crane/craneGhcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-699-61beeee \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-699-61beeee \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-699-61beeee \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-699-61beeee crane/crane |
qmhu
reviewed
Feb 22, 2023
deploy/craned/deployment.yaml
Outdated
| @@ -115,6 +115,13 @@ data: | |||
| apiVersion: apps/v1 | |||
| - kind: StatefulSet | |||
| apiVersion: apps/v1 | |||
| config: | |||
| @@ -13,6 +13,13 @@ recommenders: | |||
| apiVersion: apps/v1 | |||
| - kind: StatefulSet | |||
| apiVersion: apps/v1 | |||
| config: | |||
| HalfLife: "24h", | ||
| BucketSize: "0.1", | ||
| MaxValue: "100", | ||
| HalfLife: rr.Recommender.Config["cpu-histogram-half-life"], |
There was a problem hiding this comment.
please refer to other configuration's implement in register.go
| HalfLife: "48h", | ||
| BucketSize: "104857600", | ||
| MaxValue: "104857600000", | ||
| HalfLife: rr.Recommender.Config["mem-histogram-half-life"], |
| @@ -166,10 +166,17 @@ data: | |||
| apiVersion: apps/v1 | |||
| - kind: StatefulSet | |||
| apiVersion: apps/v1 | |||
| config: # settings for recommender | |||
There was a problem hiding this comment.
No need to add here, better to update here :https://github.com/gocrane/crane/blob/main/site/content/en/docs/Tutorials/Recommendation/resource-recommendation.md
configuration part
| @@ -166,6 +166,13 @@ data: | |||
| apiVersion: apps/v1 | |||
| - kind: StatefulSet | |||
| apiVersion: apps/v1 | |||
| config: # settings for recommender | |||
comqx
force-pushed
the
feat-extconfig
branch
from
7a0765a
to
3bf4289
Compare
github-actions
bot
added
area:recommendation
and removed
examples
deploy
area:recommendation
labels
comqx
force-pushed
the
feat-extconfig
branch
2 times, most recently
from
0da08c4
to
6ef5d02
Compare
|
All adjustments have been made according to the specification |
qmhu
reviewed
Feb 22, 2023
site/content/zh/docs/Tutorials/Recommendation/resource-recommendation.md
Outdated
Show resolved
Hide resolved
Signed-off-by: qixiang-liu <18311166263@163.com>
comqx
force-pushed
the
feat-extconfig
branch
from
6ef5d02
to
61beeee
Compare
qmhu
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it:
The resource configuration can be adjusted
Which issue(s) this PR fixes:
Fixes #
#698
Special notes for your reviewer: