Default PROMQL query syntax should not use regular expressions #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitianFresh
reviewed
Mar 3, 2022
pkg/prediction/config/config.go
Outdated
| // NodeMemUsagePromQLFmtStr is used to query node cpu memory by promql, param is node name, node name which prometheus scrape | ||
| NodeMemUsagePromQLFmtStr = `sum(node_memory_MemTotal_bytes{instance=~"^%s.*"} - node_memory_MemAvailable_bytes{instance=~"^%s.*"})` | ||
| NodeMemUsagePromQLFmtStr = `sum(node_memory_MemTotal_bytes{instance="%s"} - node_memory_MemAvailable_bytes{instance="%s"})` |
There was a problem hiding this comment.
This regex is used to match some instance including ip:port style. And it depends on your monitoring system, so we do not assume the instance is nodename or ip only.
If we modify this prom template, we need find a more general way.
There was a problem hiding this comment.
I know, so I pushed a new commit that is used to match some instance including ip:port style.
|
@shijieqin cloud you please make sure your commit messages are in English, we need to keep the project to be globalized. |
…g data to other nodes, so I change it
Sorry, I change the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeMemUsagePromQLFmtStr =
sum(node_memory_MemTotal_bytes{instance="%s"} - node_memory_MemAvailable_bytes{instance="%s"})NodeCpuUsagePromQLFmtStr =
sum(count(node_cpu_seconds_total{mode="idle",instance="%s"}) by (mode, cpu)) - sum(irate(node_cpu_seconds_total{mode="idle",instance="%s"}[%s]))The above two default queries use a regular expression, which will cause the query result that does not meet the expected expectations.