Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for EHPA recommendation #192

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

qmhu
Copy link
Member

@qmhu qmhu commented Mar 9, 2022

What type of PR is this?

feature && enhancement

What this PR does / why we need it:

enhancement for ehpa recommendation
implement recommendation updater

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@qmhu qmhu requested a review from yufeiyu March 9, 2022 03:57
pkg/recommend/advisor/ehpa.go Outdated Show resolved Hide resolved
pkg/recommend/advisor/ehpa.go Outdated Show resolved Hide resolved
pkg/recommend/advisor/ehpa.go Show resolved Hide resolved
pkg/recommend/advisor/ehpa.go Show resolved Hide resolved
@yufeiyu
Copy link
Contributor

yufeiyu commented Mar 10, 2022

/lgtm

@qmhu qmhu merged commit 8cdaeba into gocrane:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants