Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Pod ext resource to quota limit #196

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Convert Pod ext resource to quota limit #196

merged 1 commit into from
Mar 17, 2022

Conversation

chenkaiyue
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

  1. move node resource controller as node resource manager to agent
  2. add low priority pod which used ext resource qos ensurance feature in node resource manager
  3. add a data source, node resource manager can get data from both tsp and local

Special notes for your reviewer:

@chenkaiyue chenkaiyue changed the title Add node resource manager [WIP]Add node resource manager Mar 11, 2022
yan234280533
yan234280533 reviewed Mar 11, 2022
View reviewed changes
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/ensurance/collector/collector.go Outdated Show resolved Hide resolved
pkg/ensurance/collector/collector.go Outdated Show resolved Hide resolved
pkg/ensurance/node-resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/ensurance/node-resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/ensurance/node-resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/ensurance/node-resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/ensurance/node-resource/node-resource-manager.go Outdated Show resolved Hide resolved
@chenkaiyue chenkaiyue changed the title [WIP]Add node resource manager [WIP]Convert Pod ext resource to quota Mar 11, 2022
@chenkaiyue chenkaiyue changed the title [WIP]Convert Pod ext resource to quota [WIP]Convert Pod ext resource to quota limit Mar 12, 2022
@chenkaiyue chenkaiyue changed the title [WIP]Convert Pod ext resource to quota limit Convert Pod ext resource to quota limit Mar 12, 2022
mfanjie
mfanjie reviewed Mar 14, 2022
View reviewed changes
pkg/ensurance/executor/throttle.go Outdated Show resolved Hide resolved
pkg/resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/resource/pod-resource-manger.go Outdated Show resolved Hide resolved
pkg/resource/pod-resource-manger.go Outdated Show resolved Hide resolved
pkg/resource/pod-resource-manger.go Outdated Show resolved Hide resolved
@mfanjie
Copy link
Contributor

mfanjie commented Mar 14, 2022

@shijieqin moved the node resource controller in #198 as well.

yan234280533
yan234280533 reviewed Mar 14, 2022
View reviewed changes
pkg/resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/resource/pod-resource-manger.go Outdated Show resolved Hide resolved
pkg/resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/resource/node-resource-manager.go Outdated Show resolved Hide resolved
pkg/resource/node-resource-manager.go Outdated Show resolved Hide resolved
@yan234280533 yan234280533 added this to the 0.3.0 milestone Mar 14, 2022
@chenkaiyue chenkaiyue force-pushed the node-resource-manager branch 2 times, most recently from 658456d to a80f834 Compare March 14, 2022 10:03
szy441687879
szy441687879 reviewed Mar 14, 2022
View reviewed changes
pkg/ensurance/executor/throttle.go Outdated Show resolved Hide resolved
pkg/ensurance/collector/collector.go Outdated Show resolved Hide resolved
pkg/resource/pod_resource_manger.go Show resolved Hide resolved
pkg/resource/pod_resource_manger.go Outdated Show resolved Hide resolved
pkg/resource/pod_resource_manger.go Show resolved Hide resolved
qmhu
qmhu reviewed Mar 15, 2022
View reviewed changes
pkg/agent/agent.go Show resolved Hide resolved
pkg/resource/node_resource_manager.go Show resolved Hide resolved
pkg/utils/ref.go Outdated Show resolved Hide resolved
@chenkaiyue chenkaiyue force-pushed the node-resource-manager branch 2 times, most recently from 30c770c to c1d653d Compare March 15, 2022 04:27
@yan234280533
Copy link

/lgtm

1 similar comment
@szy441687879
Copy link
Contributor

/lgtm

@chenkaiyue
Copy link
Contributor Author

image

image

image

@mfanjie
Copy link
Contributor

mfanjie commented Mar 17, 2022

/lgtm

@mfanjie mfanjie merged commit ec916ae into gocrane:main Mar 17, 2022
@yan234280533 yan234280533 mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shijieqin shijieqin shijieqin left review comments

@mfanjie mfanjie mfanjie left review comments

@szy441687879 szy441687879 szy441687879 left review comments

@yan234280533 yan234280533 yan234280533 left review comments

@qmhu qmhu qmhu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chenkaiyue @mfanjie @yan234280533 @szy441687879 @qmhu @shijieqin