Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code static check with reviewdog #261

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

lbbniu
Copy link
Member

@lbbniu lbbniu commented Apr 13, 2022

What type of PR is this?

Enhancement

What this PR does / why we need it:

Add code static check

Which issue(s) this PR fixes:

Fixes #262
Static check specification adjustments

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2022

🎊 PR Preview caf5212 has been successfully built and deployed to https://gocrane-crane-preview-pr-261.surge.sh

🕐 Build time: 1.665s

🤖 By surge-preview

@lbbniu lbbniu requested a review from qmhu April 13, 2022 15:23
@lbbniu lbbniu changed the title Support code static check by reviewdog Support code golangci-lint by reviewdog Apr 14, 2022
@lbbniu lbbniu requested a review from qmhu April 22, 2022 15:21
@lbbniu lbbniu force-pushed the feature/lbbniu/reviewdog branch 4 times, most recently from f52d504 to 877ef6c Compare April 24, 2022 14:36
@lbbniu lbbniu changed the title Support code golangci-lint by reviewdog Fix golangci-lint code static check Apr 24, 2022
@lbbniu lbbniu force-pushed the feature/lbbniu/reviewdog branch 3 times, most recently from e521866 to b38d7f9 Compare April 25, 2022 03:50
@qmhu
Copy link
Member

qmhu commented Apr 25, 2022

/LGTM
@lbbniu Please squash the commits before merge.

@qmhu qmhu changed the title Fix golangci-lint code static check Add code static check with reviewdog Apr 25, 2022
@qmhu qmhu merged commit c1c26b0 into gocrane:main Apr 25, 2022
@lbbniu lbbniu deleted the feature/lbbniu/reviewdog branch April 25, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support code golangci-lint by reviewdog
2 participants