-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GetRuntimeClient compatibility #273
Conversation
🎊 PR Preview 76d5644 has been successfully built and deployed to https://gocrane-crane-preview-pr-273.surge.sh 🕐 Build time: 1.573s 🤖 By surge-preview |
@chenkaiyue Please take a look |
Thanks for your contributions. Have you tested in Kind or K3S, maybe you can paste test images here? |
bf5d5d1
to
c744466
Compare
🎉 Successfully Build Images. Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
|
I have some tests in Connect container runtime endpoint successfully, but have some permission problems.
|
https://github.com/gocrane/helm-charts/pull/46/files is this pr related to this change? |
|
ok |
@qmhu @chenkaiyue Should this bug be fixed by this pr or fixed by a separate pr? |
c744466
to
6f12558
Compare
Please squash these commits. |
6f12558
to
bda836c
Compare
Finish |
bda836c
to
2a91368
Compare
2a91368
to
6eef366
Compare
/LGTM nice job! |
/LGTM |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #232 #251 #276
Special notes for your reviewer: