add workload selector for evpa #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitianFresh
force-pushed
the
feature/use-workoadinfo-to-query-container-for-metricserver
branch
2 times, most recently
from
5537351
to
59a713a
Compare
yufeiyu
reviewed
Apr 27, 2022
kitianFresh
force-pushed
the
feature/use-workoadinfo-to-query-container-for-metricserver
branch
from
59a713a
to
59deb96
Compare
qmhu
reviewed
Apr 27, 2022
| tsList, err = utils.QueryPredictedValues(e.Predictor, caller, memConfig, memoryMetricNamer) | ||
|
|
||
| var errs []error | ||
| // first register cpu & memory, or the memory will be not registered before the cpu prediction succeed |
There was a problem hiding this comment.
Would you please make this commend more clearer.
There was a problem hiding this comment.
Would you please make this commend more clearer.
ok. originally, we call utils.QueryPredictedValues it will do register & predict. then it failed for cpu, then it will be always return directly, but the memory is not registered forever before the cpu is succeed.
so, for each predicting, we should first to register what you need to predict, then do predicting. because evpa maybe has multiple metrics for predicting, so we first register all of them, then get predicted value by reconciling
I will make it clear more
|
LGTM |
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #284
Special notes for your reviewer: