Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize trigger github action rules #293

Merged
merged 1 commit into from
May 5, 2022
Merged

Optimize trigger github action rules #293

merged 1 commit into from
May 5, 2022

Conversation

lbbniu
Copy link
Member

@lbbniu lbbniu commented Apr 29, 2022 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Optimize build images trigger github action rules

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022 •
edited
Loading

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-293-d223350 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-293-d223350
dashboard:pr-293-d223350 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-293-d223350
metric-adapter:pr-293-d223350 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-293-d223350
craned:pr-293-d223350 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-293-d223350

@lbbniu
Copy link
Member Author

lbbniu commented Apr 29, 2022 •
edited
Loading

see:
lbbniu#17
image

lbbniu#18
image

@lbbniu lbbniu changed the title Optimize build images trigger github action rules Optimize trigger github action rules Apr 29, 2022
zsnmwy
zsnmwy reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@zsnmwy zsnmwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 0aefe7e into gocrane:main May 5, 2022
@lbbniu lbbniu deleted the patch-1 branch May 16, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsnmwy zsnmwy zsnmwy left review comments

@qmhu qmhu qmhu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbbniu @qmhu @zsnmwy