Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crane dashboard crashed without prometheus service #334

Conversation

PatrickLai7528
Copy link
Collaborator

What type of PR is this?

fix: crane dashboard crashed without prometheus service

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@lbbniu
Copy link
Member

lbbniu commented May 25, 2022

What if the domain name of the k8s cluster is not cluster.local ?

@zsnmwy
Copy link
Member

zsnmwy commented May 25, 2022

Maybe we can use Lua to get the nameserver address in /etc/resolv.conf when Nginx is in bootstrap.

/ # cat /etc/resolv.conf
search default.svc.cluster.local svc.cluster.local cluster.local
nameserver 10.43.0.10
options ndots:5

We can also get cluster domain in /etc/resolv.conf.

/ # awk '/search/{print $2}' /etc/resolv.conf
default.svc.cluster.local

If it fail, then the upstream fall back to kube-dns.kube-system.svc.cluster.local.

@qmhu
Copy link
Member

qmhu commented Jun 1, 2022

/LGTM

@qmhu qmhu merged commit 131b165 into gocrane:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants