Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If ehpa is configured with prediction but does not contain predictable metrics, then no tsp object is created #340

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

whitebear009
Copy link
Contributor

What type of PR is this?

bugfix

What this PR does / why we need it:

If ehpa is configured with prediction but does not contain predictable metrics, ehpa conotroller will throw error like below:

E0531 17:15:57.094143 1 predict.go:71] Failed to create TimeSeriesPrediction khrd-geom-middleware-prod/ehpa-kigma-render-service-prod-hpa-preview error admission webhook "vprediction.crane.io" denied the request: PredictionMetrics is null
So we need to add a judgment condition, in this case, no tsp object is created.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-340-a160190 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-340-a160190
dashboard:pr-340-a160190 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-340-a160190
metric-adapter:pr-340-a160190 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-340-a160190
craned:pr-340-a160190 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-340-a160190

@qmhu
Copy link
Member

qmhu commented Jun 1, 2022

/LGTM

@qmhu qmhu merged commit 1ee09b4 into gocrane:main Jun 1, 2022
@whitebear009 whitebear009 deleted the tsp branch June 10, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants