Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for DSP #414

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Add doc for DSP #414

merged 3 commits into from
Jul 15, 2022

Conversation

yufeiyu
Copy link
Contributor

@yufeiyu yufeiyu commented Jul 15, 2022

What type of PR is this?

doc

What this PR does / why we need it:

tutorial doc for DSP algorithm

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022 •
edited
Loading

♻️ PR Preview fe477cb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022 •
edited
Loading

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-414-fe477cb docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-414-fe477cb
dashboard:pr-414-fe477cb docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-414-fe477cb
metric-adapter:pr-414-fe477cb docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-414-fe477cb
craned:pr-414-fe477cb docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-414-fe477cb

qmhu
qmhu reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to put related images into a sub folder , e.g. docs/images/algorithm/

@yufeiyu
Copy link
Contributor Author

yufeiyu commented Jul 15, 2022

Better to put related images into a sub folder , e.g. docs/images/algorithm/

done

xieydd
xieydd approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@xieydd xieydd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need fix ci error in https://github.com/gocrane/crane/runs/7353097449?check_suite_focus=true

golangci-lint ...

@yufeiyu
Copy link
Contributor Author

yufeiyu commented Jul 15, 2022

LGTM, but we need fix ci error in https://github.com/gocrane/crane/runs/7353097449?check_suite_focus=true

golangci-lint ...

fixed

qmhu
qmhu approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 44bb190 into gocrane:main Jul 15, 2022
@yufeiyu yufeiyu linked an issue Jul 15, 2022 that may be closed by this pull request
Provide a practice guide on how to TSP dsp configuration #392
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xieydd xieydd xieydd approved these changes

@qmhu qmhu qmhu approved these changes

@chenkaiyue chenkaiyue Awaiting requested review from chenkaiyue

@kitianFresh kitianFresh Awaiting requested review from kitianFresh

@mfanjie mfanjie Awaiting requested review from mfanjie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a practice guide on how to TSP dsp configuration
3 participants
@yufeiyu @qmhu @xieydd