Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pkg-utils-string #480

Merged
merged 1 commit into from
Aug 16, 2022
Merged

test: pkg-utils-string #480

merged 1 commit into from
Aug 16, 2022

Conversation

jxs1211
Copy link
Contributor

@jxs1211 jxs1211 commented Aug 15, 2022

Signed-off-by: xian-jie.shen 327411586@qq.com

What type of PR is this?

ut for function

What this PR does / why we need it:

ut for function

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

[going@dev utils]$ go test string_test.go string.go -cover
ok      command-line-arguments  0.003s  coverage: 100.0% of statements
[going@dev utils]$ cd ..
[going@dev pkg]$ cd ..
[going@dev crane]$ make lint
[going@dev crane]$ gs
On branch test-pkg-utils-string
nothing to commit, working tree clean

Signed-off-by: xian-jie.shen <327411586@qq.com>
@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-15 20:42
Git Version: 262a935

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-480-262a935 docker pull gocrane/crane-agent:pr-480-262a935
dashboard:pr-480-262a935 docker pull gocrane/dashboard:pr-480-262a935
metric-adapter:pr-480-262a935 docker pull gocrane/metric-adapter:pr-480-262a935
craned:pr-480-262a935 docker pull gocrane/craned:pr-480-262a935

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-480-262a935 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-480-262a935 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-480-262a935 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-480-262a935 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-480-262a935 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-480-262a935
dashboard:pr-480-262a935 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-480-262a935
metric-adapter:pr-480-262a935 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-480-262a935
craned:pr-480-262a935 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-480-262a935

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-480-262a935 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-480-262a935 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-480-262a935 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-480-262a935 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-480-262a935 docker pull ghcr.io/gocrane/crane/crane-agent:pr-480-262a935
dashboard:pr-480-262a935 docker pull ghcr.io/gocrane/crane/dashboard:pr-480-262a935
metric-adapter:pr-480-262a935 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-480-262a935
craned:pr-480-262a935 docker pull ghcr.io/gocrane/crane/craned:pr-480-262a935

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-480-262a935 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-480-262a935 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-480-262a935 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-480-262a935 crane/crane

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 9c12d3f into gocrane:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants