Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to nodeqos and podqos api #481

Merged
merged 5 commits into from
Aug 30, 2022
Merged

adapt to nodeqos and podqos api #481

merged 5 commits into from
Aug 30, 2022

Conversation

mfanjie
Copy link
Contributor

@mfanjie mfanjie commented Aug 16, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-30 10:40
Git Version: e532c08

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-481-e532c08 docker pull gocrane/crane-agent:pr-481-e532c08
dashboard:pr-481-e532c08 docker pull gocrane/dashboard:pr-481-e532c08
metric-adapter:pr-481-e532c08 docker pull gocrane/metric-adapter:pr-481-e532c08
craned:pr-481-e532c08 docker pull gocrane/craned:pr-481-e532c08

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-481-e532c08 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-481-e532c08 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-481-e532c08 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-481-e532c08 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-481-e532c08 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-481-e532c08
dashboard:pr-481-e532c08 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-481-e532c08
metric-adapter:pr-481-e532c08 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-481-e532c08
craned:pr-481-e532c08 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-481-e532c08

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-481-e532c08 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-481-e532c08 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-481-e532c08 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-481-e532c08 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-481-e532c08 docker pull ghcr.io/gocrane/crane/crane-agent:pr-481-e532c08
dashboard:pr-481-e532c08 docker pull ghcr.io/gocrane/crane/dashboard:pr-481-e532c08
metric-adapter:pr-481-e532c08 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-481-e532c08
craned:pr-481-e532c08 docker pull ghcr.io/gocrane/crane/craned:pr-481-e532c08

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-481-e532c08 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-481-e532c08 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-481-e532c08 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-481-e532c08 crane/crane

@chenkaiyue
Copy link
Contributor

chenkaiyue commented Aug 25, 2022

mfanjie#1

  1. Update scheduling merge action
  2. Add label selector in podqos match logic

@mfanjie mfanjie force-pushed the main branch 4 times, most recently from 12cf9d8 to 47cebe6 Compare August 30, 2022 01:54
Copy link
Contributor

@chenkaiyue chenkaiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenkaiyue chenkaiyue merged commit b655937 into gocrane:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants