Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Add labels from recommendation #492

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

qmhu
Copy link
Member

@qmhu qmhu commented Aug 18, 2022

Signed-off-by: qmhu brillantroad@gmail.com

What type of PR is this?

bugfix

What this PR does / why we need it:

add labels from recommendation to fix bug : duplicated recommendations.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: qmhu <brillantroad@gmail.com>
@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-19 02:47
Git Version: 8fee431

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-492-8fee431 docker pull gocrane/crane-agent:pr-492-8fee431
dashboard:pr-492-8fee431 docker pull gocrane/dashboard:pr-492-8fee431
metric-adapter:pr-492-8fee431 docker pull gocrane/metric-adapter:pr-492-8fee431
craned:pr-492-8fee431 docker pull gocrane/craned:pr-492-8fee431

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-492-8fee431 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-492-8fee431 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-492-8fee431 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-492-8fee431 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-492-8fee431 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-492-8fee431
dashboard:pr-492-8fee431 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-492-8fee431
metric-adapter:pr-492-8fee431 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-492-8fee431
craned:pr-492-8fee431 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-492-8fee431

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-492-8fee431 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-492-8fee431 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-492-8fee431 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-492-8fee431 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-492-8fee431 docker pull ghcr.io/gocrane/crane/crane-agent:pr-492-8fee431
dashboard:pr-492-8fee431 docker pull ghcr.io/gocrane/crane/dashboard:pr-492-8fee431
metric-adapter:pr-492-8fee431 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-492-8fee431
craned:pr-492-8fee431 docker pull ghcr.io/gocrane/crane/craned:pr-492-8fee431

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-492-8fee431 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-492-8fee431 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-492-8fee431 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-492-8fee431 crane/crane

@qmhu qmhu requested a review from xieydd August 19, 2022 02:50
Copy link
Member

@xieydd xieydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 485a32b into gocrane:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants