Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer-guide.md and some images. #512

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

JaneConan
Copy link
Contributor

What type of PR is this?

For crane's developer, Add a developer guidebook.

This Developer's Guide document to let new craner to know how to contribute code.

What this PR does / why we need it:

  • Introduce to clone the project.

  • Introduce to build binary and images from code.

Which issue(s) this PR fixes:

Implement #459

Special notes for your reviewer:

For local developers, we also need to solicit suggestions after the release of the manual so that we can complete it. Thx~

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

♻️ PR Preview 71eb198 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@zsnmwy
Copy link
Member

zsnmwy commented Aug 22, 2022

Thanks for your pull request.

Crane uses the mkdocs to build web docs.
Please make your docs adjust mkdocs.
It's easy to complete it.


  1. python env 3.x
  2. install packages
    - uses: actions/setup-python@v2
    with:
    python-version: "3.9"
    - run: pip install mkdocs-material mkdocs-static-i18n mike
  3. mkdocs local preview
    mkdocs serve -a 127.0.0.1:9999
  4. Add docs path to mkdocs.yml
  5. Change the format of your docs.

You can ref to the complete docs.
Please ensure that the directory is clearly structured.

@JaneConan
Copy link
Contributor Author

THX a lot~

Let me have a try~

And I will implement this md with mkdocs.yml

Next, I push again~

@zsnmwy
Copy link
Member

zsnmwy commented Aug 22, 2022

If possible, I hope the docs include these items.

#499 (comment)

@JaneConan
Copy link
Contributor Author

JaneConan commented Aug 22, 2022

If possible, I hope the docs include these items.

#499 (comment)

Sure~

  • How to build binary and images from code

That means "Don't use makefile, just use bash or cmd command line?"


  • How to prepare local environments

  • go version

  • application bootstrap

  • the local application connects to the remote k8s cluster.

  • application debug

Can we put it in the next sprint? I'm also studying and researching these things.

And I suggest we ask to our friends again, what else is needed?

Thx~(^_^)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-22 23:10
Git Version: 71eb198

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-512-71eb198 docker pull gocrane/crane-agent:pr-512-71eb198
dashboard:pr-512-71eb198 docker pull gocrane/dashboard:pr-512-71eb198
metric-adapter:pr-512-71eb198 docker pull gocrane/metric-adapter:pr-512-71eb198
craned:pr-512-71eb198 docker pull gocrane/craned:pr-512-71eb198

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-512-71eb198 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-512-71eb198 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-512-71eb198 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-512-71eb198 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-512-71eb198 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-512-71eb198
dashboard:pr-512-71eb198 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-512-71eb198
metric-adapter:pr-512-71eb198 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-512-71eb198
craned:pr-512-71eb198 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-512-71eb198

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-512-71eb198 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-512-71eb198 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-512-71eb198 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-512-71eb198 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-512-71eb198 docker pull ghcr.io/gocrane/crane/crane-agent:pr-512-71eb198
dashboard:pr-512-71eb198 docker pull ghcr.io/gocrane/crane/dashboard:pr-512-71eb198
metric-adapter:pr-512-71eb198 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-512-71eb198
craned:pr-512-71eb198 docker pull ghcr.io/gocrane/crane/craned:pr-512-71eb198

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-512-71eb198 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-512-71eb198 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-512-71eb198 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-512-71eb198 crane/crane

docs/developer-guide.md Outdated Show resolved Hide resolved
docs/developer-guide.md Outdated Show resolved Hide resolved
@zsnmwy
Copy link
Member

zsnmwy commented Aug 22, 2022

If possible, I hope the docs include these items.
#499 (comment)

Sure~

  • How to build binary and images from code

That means "Don't use makefile, just use bash or cmd command line?"

  • How to prepare local environments
  • go version
  • application bootstrap
  • the local application connects to the remote k8s cluster.
  • application debug

Can we put it in the next sprint? I'm also studying and researching these things.

And I suggest we ask to our friends again, what else is needed?

Thx~(^^_)

Makefile is all right.


Sure, I hope your next pr.

@JaneConan
Copy link
Contributor Author

「weopen star」☆⌒(*^-゜)v THX for @zsnmwy @qmhu !! Go! Go! Go! to next star~

@JaneConan JaneConan requested a review from zsnmwy August 22, 2022 16:00
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu
Copy link
Member

qmhu commented Aug 22, 2022

Thanks for you effort, welcome to join crane 👍

Copy link
Member

@zsnmwy zsnmwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zsnmwy zsnmwy merged commit 149f15d into gocrane:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants