Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some klog typo #543

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix some klog typo #543

merged 1 commit into from
Sep 6, 2022

Conversation

whitebear009
Copy link
Contributor

@whitebear009 whitebear009 commented Sep 2, 2022

What type of PR is this?

fix klog typo

What this PR does / why we need it:

There are currently some format errors in the log, like:
image

Which issue(s) this PR fixes:

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-09-06 18:48
Git Version: 8a98e8f

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-543-8a98e8f docker pull gocrane/crane-agent:pr-543-8a98e8f
dashboard:pr-543-8a98e8f docker pull gocrane/dashboard:pr-543-8a98e8f
metric-adapter:pr-543-8a98e8f docker pull gocrane/metric-adapter:pr-543-8a98e8f
craned:pr-543-8a98e8f docker pull gocrane/craned:pr-543-8a98e8f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-543-8a98e8f \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-543-8a98e8f \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-543-8a98e8f \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-543-8a98e8f crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-543-8a98e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-543-8a98e8f
dashboard:pr-543-8a98e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-543-8a98e8f
metric-adapter:pr-543-8a98e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-543-8a98e8f
craned:pr-543-8a98e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-543-8a98e8f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-543-8a98e8f \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-543-8a98e8f \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-543-8a98e8f \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-543-8a98e8f crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-543-8a98e8f docker pull ghcr.io/gocrane/crane/crane-agent:pr-543-8a98e8f
dashboard:pr-543-8a98e8f docker pull ghcr.io/gocrane/crane/dashboard:pr-543-8a98e8f
metric-adapter:pr-543-8a98e8f docker pull ghcr.io/gocrane/crane/metric-adapter:pr-543-8a98e8f
craned:pr-543-8a98e8f docker pull ghcr.io/gocrane/crane/craned:pr-543-8a98e8f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-543-8a98e8f \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-543-8a98e8f \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-543-8a98e8f \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-543-8a98e8f crane/crane

@whitebear009
Copy link
Contributor Author

whitebear009 commented Sep 2, 2022

/assign @qmhu
Please review, thanks~

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 2a9693c into gocrane:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants