Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: optimized nginx configuration #548

Merged
merged 1 commit into from
Sep 12, 2022
Merged

pref: optimized nginx configuration #548

merged 1 commit into from
Sep 12, 2022

Conversation

lbbniu
Copy link
Member

@lbbniu lbbniu commented Sep 8, 2022

What type of PR is this?

optimized nginx configuration

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions github-actions bot added the deploy label Sep 8, 2022
@@ -150,6 +150,17 @@ metadata:
name: nginx-conf
namespace: crane-system
data:
common_params: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to make it take effect when you move to here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include conf.d/common_params;

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 783399f into gocrane:main Sep 12, 2022
@lbbniu
Copy link
Member Author

lbbniu commented Sep 13, 2022

/LGTM
Sync update
gocrane/helm-charts#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants