Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hide managedFields by default when display YAML #587

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango xu.weiKyrie@foxmail.com

What type of PR is this?

/chore

What this PR does / why we need it:

Hide managedFields by default when display YAML

Which issue(s) this PR fixes:

Fixes #504

Special notes for your reviewer:

None

@mfanjie
Copy link
Contributor

mfanjie commented Oct 21, 2022

+1, I hate managedFields

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-10-24 15:16
Git Version: fbd5393

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-587-fbd5393 docker pull gocrane/crane-agent:pr-587-fbd5393
dashboard:pr-587-fbd5393 docker pull gocrane/dashboard:pr-587-fbd5393
metric-adapter:pr-587-fbd5393 docker pull gocrane/metric-adapter:pr-587-fbd5393
craned:pr-587-fbd5393 docker pull gocrane/craned:pr-587-fbd5393

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-587-fbd5393 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-587-fbd5393 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-587-fbd5393 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-587-fbd5393 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-587-fbd5393 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-587-fbd5393
dashboard:pr-587-fbd5393 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-587-fbd5393
metric-adapter:pr-587-fbd5393 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-587-fbd5393
craned:pr-587-fbd5393 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-587-fbd5393

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-587-fbd5393 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-587-fbd5393 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-587-fbd5393 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-587-fbd5393 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-587-fbd5393 docker pull ghcr.io/gocrane/crane/crane-agent:pr-587-fbd5393
dashboard:pr-587-fbd5393 docker pull ghcr.io/gocrane/crane/dashboard:pr-587-fbd5393
metric-adapter:pr-587-fbd5393 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-587-fbd5393
craned:pr-587-fbd5393 docker pull ghcr.io/gocrane/crane/craned:pr-587-fbd5393

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-587-fbd5393 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-587-fbd5393 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-587-fbd5393 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-587-fbd5393 crane/crane

@PatrickLai7528
Copy link
Collaborator

Removing manageField from ts declaration is not going to achieve you purpose.

Maybe you should transform yaml to js object after fetching yaml api, delete managefield property from it, then transform back to yaml and show it

@mangoGoForward
Copy link
Contributor Author

Removing manageField from ts declaration is not going to achieve you purpose.

Maybe you should transform yaml to js object after fetching yaml api, delete managefield property from it, then transform back to yaml and show it

Thanks, I will try

Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@mangoGoForward
Copy link
Contributor Author

Hi @mfanjie @PatrickLai7528 I have tested and this screenshot like below:

image

Copy link
Collaborator

@PatrickLai7528 PatrickLai7528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@qmhu qmhu merged commit ad18849 into gocrane:main Oct 24, 2022
@mangoGoForward mangoGoForward deleted the chore/hide-managedFields branch October 25, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide managedFields by default when display YAML
4 participants