Override recommder parameter with the config in RecommendationRule #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmhu
reviewed
Dec 14, 2022
| } | ||
|
|
||
| // Override the default value with RecommendationConfiguration in configmap | ||
| if err = SetRecommendationConfig(rr, recommender.Config); err != nil { |
There was a problem hiding this comment.
- merge recommender.Config and recommendationRule.Spec.Config first
- do other initialization steps
There was a problem hiding this comment.
- if the value in recommender.Config and recommendationRule.Spec.Config conflict, I will use the value of recommendationRule. Is that right?
There was a problem hiding this comment.
- if the value in recommender.Config and recommendationRule.Spec.Config conflict, I will use the value of recommendationRule. Is that right?
yes, recommendationRule.Spec.Config has the highest priority.
There was a problem hiding this comment.
also, api change PR should be merged first and use the newest api version in crane
whitebear009
force-pushed
the
add-config-for-recommendationrule
branch
2 times, most recently
from
181fe9a
to
f3177ff
Compare
|
gocrane/api#74 has merged, and you can run |
whitebear009
force-pushed
the
add-config-for-recommendationrule
branch
from
f3177ff
to
f905eb2
Compare
|
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-648-f4c2ee1 \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-648-f4c2ee1 \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-648-f4c2ee1 \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-648-f4c2ee1 crane/craneCoding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-648-f4c2ee1 \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-648-f4c2ee1 \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-648-f4c2ee1 \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-648-f4c2ee1 crane/craneGhcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-648-f4c2ee1 \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-648-f4c2ee1 \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-648-f4c2ee1 \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-648-f4c2ee1 crane/crane |
|
@qmhu it's done. please check. |
qmhu
reviewed
Dec 15, 2022
| @@ -21,10 +21,19 @@ func (inr *IdleNodeRecommender) Name() string { | |||
| } | |||
|
|
|||
| // NewIdleNodeRecommender create a new idle node recommender. | |||
| func NewIdleNodeRecommender(recommender apis.Recommender) (*IdleNodeRecommender, error) { | |||
| func NewIdleNodeRecommender(recommender apis.Recommender, recommendationRuleConfig map[string]string) (*IdleNodeRecommender, error) { | |||
| if recommender.Config == nil { | |||
| recommender.Config = map[string]string{} | |||
| } | |||
There was a problem hiding this comment.
Could you extract these line into a common function?
|
/hold |
whitebear009
force-pushed
the
add-config-for-recommendationrule
branch
from
e655bba
to
f4c2ee1
Compare
qmhu
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimization
What this PR does / why we need it:
Override the RecommendationConfiguration in configmap and the default value with the config in RecommendationRule
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: