Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the node label replace error #682

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix the node label replace error #682

merged 1 commit into from
Jan 19, 2023

Conversation

qmhu
Copy link
Member

@qmhu qmhu commented Jan 17, 2023

What type of PR is this?

bugfix

What this PR does / why we need it:

In some cluster, the node label is the ip:port format, the origin promql will failed in these clusters.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-01-19 10:56
Git Version: bae03d5

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-682-bae03d5 docker pull gocrane/crane-agent:pr-682-bae03d5
dashboard:pr-682-bae03d5 docker pull gocrane/dashboard:pr-682-bae03d5
metric-adapter:pr-682-bae03d5 docker pull gocrane/metric-adapter:pr-682-bae03d5
craned:pr-682-bae03d5 docker pull gocrane/craned:pr-682-bae03d5

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-682-bae03d5 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-682-bae03d5 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-682-bae03d5 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-682-bae03d5 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-682-bae03d5 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-682-bae03d5
dashboard:pr-682-bae03d5 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-682-bae03d5
metric-adapter:pr-682-bae03d5 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-682-bae03d5
craned:pr-682-bae03d5 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-682-bae03d5

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-682-bae03d5 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-682-bae03d5 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-682-bae03d5 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-682-bae03d5 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-682-bae03d5 docker pull ghcr.io/gocrane/crane/crane-agent:pr-682-bae03d5
dashboard:pr-682-bae03d5 docker pull ghcr.io/gocrane/crane/dashboard:pr-682-bae03d5
metric-adapter:pr-682-bae03d5 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-682-bae03d5
craned:pr-682-bae03d5 docker pull ghcr.io/gocrane/crane/craned:pr-682-bae03d5

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-682-bae03d5 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-682-bae03d5 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-682-bae03d5 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-682-bae03d5 crane/crane

@qmhu qmhu merged commit 1dcfdd8 into gocrane:main Jan 19, 2023
@kubehan kubehan mentioned this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant