-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update services plugin #808
Conversation
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-808-56e5852 \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-808-56e5852 \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-808-56e5852 \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-808-56e5852 crane/crane Coding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-808-56e5852 \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-808-56e5852 \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-808-56e5852 \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-808-56e5852 crane/crane Ghcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-808-56e5852 \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-808-56e5852 \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-808-56e5852 \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-808-56e5852 crane/crane |
if cpuRequestUtilization := inr.getMaxValue(inr.cpuRequestUtilization, ctx.InputValue(cpuRequestUtilizationKey)); cpuRequestUtilization > inr.cpuRequestUtilization { | ||
return fmt.Errorf("Node %s is not a idle node, because the config value is %f, but the node max cpu request utilization is %f ", ctx.Object.GetName(), inr.cpuRequestUtilization, cpuRequestUtilization) | ||
if inr.cpuRequestUtilization != 0 { | ||
cpuRequestUtilization, err := inr.BaseRecommender.GetPercentile(inr.cpuRequestUtilization, ctx.InputValue(cpuRequestUtilizationKey)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first argument should be inr.cpuPercentile
if memoryRequestUtilization := inr.getMaxValue(inr.memoryRequestUtilization, ctx.InputValue(memoryRequestUtilizationKey)); memoryRequestUtilization > inr.memoryRequestUtilization { | ||
return fmt.Errorf("Node %s is not a idle node, because the config value is %f, but the node max memory request utilization is %f ", ctx.Object.GetName(), inr.memoryRequestUtilization, memoryRequestUtilization) | ||
if inr.memoryRequestUtilization != 0 { | ||
memoryRequestUtilization, err := inr.BaseRecommender.GetPercentile(inr.memoryRequestUtilization, ctx.InputValue(memoryRequestUtilizationKey)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first argument should be inr.memoryPercentile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a mistake...
@lbbniu PTAL |
LGTM |
What type of PR is this?
Feature
What this PR does / why we need it:
Update services plugin
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: