fix: Orphan Volume judgment logic

pkg/recommendation/framework/context.go

@@ -69,8 +69,6 @@ type RecommendationContext struct {
 	Scale *autoscalingapiv1.Scale
 	// Pods in recommendation
 	Pods []corev1.Pod
-	// PVCs in recommendation
-	PVCs []corev1.PersistentVolumeClaim
 	// HPA Object
 	HPA *autoscalingv2.HorizontalPodAutoscaler
 	// HPA Object
@@ -180,15 +178,6 @@ func RetrieveScale(ctx *RecommendationContext) error {
 	return nil
 }
 
-func RetrievePersistentVolumeClaims(ctx *RecommendationContext) error {
-	if ctx.Recommendation.Spec.TargetRef.Kind == "PersistentVolume" {
-		pvcs, err := utils.GetPersistentVolumeClaims(ctx.Client, ctx.Recommendation.Spec.TargetRef.Name)
-		ctx.PVCs = pvcs
-		return err
-	}
-	return nil
-}
-
 func RetrievePods(ctx *RecommendationContext) error {
 	if ctx.Recommendation.Spec.TargetRef.Kind == "Node" {
 		pods, err := utils.GetNodePods(ctx.Client, ctx.Recommendation.Spec.TargetRef.Name)

pkg/recommendation/recommender/volumes/filter.go

@@ -1,6 +1,8 @@
 package volumes
 
 import (
+	corev1 "k8s.io/api/core/v1"
+
 	"github.com/gocrane/crane/pkg/recommendation/framework"
 	"github.com/gocrane/crane/pkg/utils"
 )
@@ -14,15 +16,16 @@ func (vr *VolumesRecommender) Filter(ctx *framework.RecommendationContext) error
 		return err
 	}
 
-	if err = framework.RetrievePersistentVolumeClaims(ctx); err != nil {
+	var pv corev1.PersistentVolume
+	if err = framework.ObjectConversion(ctx.Object, &pv); err != nil {
 		return err
 	}
 
-	if len(ctx.PVCs) == 0 {
+	if pv.Spec.ClaimRef == nil {
 		return nil
 	}
 
-	if ctx.Pods, err = utils.GetNamespacePods(ctx.Client, ctx.PVCs[0].GetNamespace()); err != nil {
+	if ctx.Pods, err = utils.GetNamespacePods(ctx.Client, pv.Spec.ClaimRef.Namespace); err != nil {
 		return err
 	}
 

pkg/recommendation/recommender/volumes/recommend.go

@@ -3,6 +3,8 @@ package volumes
 import (
 	"fmt"
 
+	corev1 "k8s.io/api/core/v1"
+
 	"github.com/gocrane/crane/pkg/recommendation/framework"
 )
 
@@ -13,15 +15,17 @@ func (vr *VolumesRecommender) PreRecommend(ctx *framework.RecommendationContext)
 func (vr *VolumesRecommender) Recommend(ctx *framework.RecommendationContext) error {
 	// Check if each volume is being used by any pods
 	isOrphanVolume := true
+	var pv corev1.PersistentVolume
+	if err := framework.ObjectConversion(ctx.Object, &pv); err != nil {
+		return err
+	}
 	for _, pod := range ctx.Pods {
 		for _, volumeClaim := range pod.Spec.Volumes {
 			if volumeClaim.PersistentVolumeClaim == nil {
 				continue
 			}
-			for _, pvc := range ctx.PVCs {
-				if volumeClaim.PersistentVolumeClaim.ClaimName == pvc.Name {
-					isOrphanVolume = false
-				}
+			if volumeClaim.PersistentVolumeClaim.ClaimName == pv.Spec.ClaimRef.Name {
+				isOrphanVolume = false
 			}
 		}
 	}

pkg/utils/pod.go

@@ -324,20 +324,6 @@ func GetNamespacePods(kubeClient client.Client, namespace string) ([]corev1.Pod,
 	return pods.Items, nil
 }
 
-// GetPersistentVolumeClaims returns Persistent Volume Claims
-func GetPersistentVolumeClaims(kubeClient client.Client, name string) ([]corev1.PersistentVolumeClaim, error) {
-	// Get a list of bind pvc
-	opts := []client.ListOption{
-		client.MatchingFields{"spec.volumeName": name},
-	}
-	pvcList := &corev1.PersistentVolumeClaimList{}
-	if err := kubeClient.List(context.Background(), pvcList, opts...); err != nil {
-		return nil, err
-	}
-
-	return pvcList.Items, nil
-}
-
 func GetServicePods(kubeClient client.Client, svc *corev1.Service) ([]corev1.Pod, error) {
 	opts := []client.ListOption{
 		client.InNamespace(svc.Namespace),