Add unit tests for match function in analytics controller #97
Conversation
|
@alierkilic thanks for you contribution, you can combine your unit test into one like :https://github.com/gocrane/crane/blob/main/pkg/controller/ehpa/hpa_test.go#L6 |
|
Should I mock the function calls inside Reconcile, SetupWithManager and createRecommendation? I don't see gomock used in the project. |
|
@alierkilic mock testing are wanted! you don't see those tests because we are still focusing on core feature development. It's perfect if you can start from such tasks. |
|
can you squash commits of this PR? |
|
@mfanjie I will start working on it |
alierkilic
force-pushed
the
main
branch
4 times, most recently
from
3070a13
to
0fc3bd2
Compare
|
@alierkilic you can still refine this pr and merge the commit, more UT can be done in separated PR. |
|
@mfanjie can you accept this PR? If the merge commit is a problem, I can force push an older head, merge and then add my changes. It was like that before. I think I accidentally closed it. |
|
plz squash commits |
Signed-off-by: alierkilic <erkilic.alican@gmail.com> Refactor unit test for match function Signed-off-by: alierkilic <erkilic.alican@gmail.com> Add unit test for match function in analytics controller
@mfanjie done |
|
/lgtm |
This will address issue: Unit tests for crane #91
If you have any problems with the test names please let me know