Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blockVariationPicker with Form block #1355

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Feb 13, 2020

Description

Experimental APIs have been pushed to stable in Gutenberg 7.5 and are expected to land in WordPress 5.4. This PR changes the references to these experimental APIs in favor of the stable versions as can be seen in WordPress/gutenberg#19966 and WordPress/gutenberg#20068

Screenshots

Using Undo Hotkey
formBlockFixes

Types of changes

Maintain backward compatibility for WordPress 5.3.2 as well as support for Gutenberg 7.5 (and likely WordPress 5.4)

How has this been tested?

Tested with and without Gutenberg 7.5 active and found the Form block template selector functional.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Type] Bug Something that is not working as expected [Status] Needs Review Tracking pull requests that need another set of eyes [Type] Gutenberg Issues/PRs related to the current version of the Gutenberg plugin labels Feb 13, 2020
@AnthonyLedesma AnthonyLedesma self-assigned this Feb 13, 2020
@AnthonyLedesma AnthonyLedesma marked this pull request as ready for review February 13, 2020 17:44
@AnthonyLedesma AnthonyLedesma changed the title resolve issues with Form block template selector Implement blockVariationPicker with Form block Feb 13, 2020
@cypress
Copy link

cypress bot commented Feb 13, 2020



Test summary

3 0 0 0


Run details

Project CoBlocks
Status Passed
Commit 9e6fc33
Started Feb 13, 2020 8:22 PM
Ended Feb 13, 2020 8:22 PM
Duration 00:33 💡
OS Linux Debian - 10.2
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor richtabor added this to the Next Release milestone Feb 19, 2020
@richtabor richtabor merged commit 5c2e89a into master Feb 19, 2020
@richtabor richtabor deleted the form-block-fix-gb75 branch February 19, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review Tracking pull requests that need another set of eyes [Type] Bug Something that is not working as expected [Type] Gutenberg Issues/PRs related to the current version of the Gutenberg plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants