Added the ability to vertically align content in row blocks #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHerman
added
[Type] Enhancement
EvanHerman
changed the title
EvanHerman
changed the title
|
@EvanHerman One additional bit we need to account for is if a user is running < Gutenberg 5.4 or < WordPress 5.2, neither of which have the Currently the editor breaks when you turn off the Gutenberg plugin and run this branch. |
|
Request on wp.org came in regarding this change. |
|
Yea but we can't merge this until WordPress 5.3 comes out :( |
|
This PR was based on CoBlocks 1.9.2 and has a number of conflicts. Started new branch |
EvanHerman
force-pushed
the
master
branch
7 times, most recently
from
5136139 to
e05908c
Compare
|
Closing as the core Columns block supports this now, as well as most other Row block features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #374
Vertical alignment was enabled in Gutenberg core in a recent release
WordPress/gutenberg#13989
This PR enables the vertical alignment toolbar for inner blocks inside of a row block.
https://cloudup.com/cxNfpe43_El
Note
When an image is added to a row, the `resize