-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional links to individual gallery images #580
Conversation
This only works with the Stacked and Masonry blocks, as the carousel does not support links at all (currently). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, 1 note but no change required.
Looks ready to go! |
@jrtashjian Should we wait to merge this before the Jest tests? |
@richtabor we will need to implement integration tests to test this out, which are going to come at a later time. Let's go ahead and merge this one. |
Is there a plan to add this to carousel blocks as well? |
Not immediately, though that's something I do want to look into. If I recall correctly, the big issue was figuring out how to properly navigate the carousel within the editor to add links - as currently, if you let off of the carousel (for example, to click into a URL field for an image), it resets the carousel instead of keeping it in place. If you have any ideas, I'm all ears :) |
This PR enables users to add individual links to gallery images within our gallery blocks (a common support request from WordPress.org).
There's still a few loose ends:
Preview: