-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the payment form context in the session #696
Conversation
woocommerce/payment-gateway/class-sv-wc-payment-gateway-payment-form.php
Outdated
Show resolved
Hide resolved
…nditionsAcceptance method
@agibson-godaddy So, I got carried away a bit here 😅 At first, I wanted to add unit test for the new Ref: 34b27ab...dc8f67c I am not sure why Github doesn't see the |
That could definitely be the problem. Runner pools are per-organization, and every repo added is assumed to be part of that org. So we can't even add this repo to our existing runner pool because of that. We'd have to create a separate runner pool. I don't know for certain that's what's causing the instant error, but it's definitely a problem anyway that we have to fix! I can take a look at this today to see if I can get it running. Nice work on the tests!!! 🙌 |
@nmolham-godaddy Reworked to drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM
Summary
Related: https://github.com/gdcorp-partners/woocommerce-gateway-elavon/pull/103
This sets the page context in the session when rendering the payment forms.
Release: #1234 (release PR)
Details
EnumTrait
frommwc-common
QA
If applicable, add specific steps for the reviewer to perform as part of their QA process prior to approving this pull request. Steps should be in a step -> success? format, like below
Setup
Before merge