Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

npm package workaround #12

Closed
wants to merge 1 commit into from
Closed

Conversation

caseytin
Copy link

@caseytin caseytin commented Aug 7, 2019

Using certain npm modules produces strange errors despite being installed in package.json or package-lock.json (see: peaksandpies/universal-analytics#58). Adding this block in the webpack config allows storybook to ignore the version conflicts.

@@ -21,6 +21,14 @@ module.exports = function config({ config: webpackConfig }) {
});
}

// Workaround for npm's fs package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that this works in your project? If so, can you add a comment here indicating that this is "so that webpack can handle *.json files."

request/request#1529 (comment)

Copy link
Contributor

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be accomplished using existing hooks exposed by exemplar. Let's chat about it tomorrow when we pair program on your project.

@rxmarbles
Copy link
Member

repo has been archived

@rxmarbles rxmarbles closed this Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants