Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint v8 #156

Merged
merged 7 commits into from
Jan 12, 2022
Merged

Eslint v8 #156

merged 7 commits into from
Jan 12, 2022

Conversation

kawikabader
Copy link
Contributor

Updates made to support using Eslint v8.

msluther
msluther reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@msluther msluther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a new major rev to me, are there other things we'd want to do before publishing? Do we want a new minimum version of eslint? Have we tested this with using older versions?

packages/eslint-config-godaddy-flow/package.json Show resolved Hide resolved
jpage-godaddy
jpage-godaddy approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@jpage-godaddy jpage-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the peerDependencies suggestion for eslint, looks good to me.

@kawikabader kawikabader merged commit 8cdca8b into main Jan 12, 2022
@kawikabader kawikabader deleted the upgrade-to-eslint-8 branch January 12, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinetifex kinetifex kinetifex approved these changes

@rxmarbles rxmarbles rxmarbles approved these changes

@jpage-godaddy jpage-godaddy jpage-godaddy approved these changes

@3rd-Eden 3rd-Eden Awaiting requested review from 3rd-Eden

@burgessa23 burgessa23 Awaiting requested review from burgessa23

@DullReferenceException DullReferenceException Awaiting requested review from DullReferenceException

@Swaagie Swaagie Awaiting requested review from Swaagie

@msluther msluther Awaiting requested review from msluther

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kawikabader @kinetifex @rxmarbles @msluther @jpage-godaddy