Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge artifactory references #164

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Purge artifactory references #164

merged 1 commit into from
Jun 24, 2022

Conversation

jpage-godaddy
Copy link
Contributor

@jpage-godaddy jpage-godaddy commented Jun 24, 2022 •
edited
Loading

Fixes #158

@jpage-godaddy
Copy link
Contributor Author

Is this "cicd" check ever going to do something, or is the repo configured incorrectly? It doesn't look like I can bypass the check and merge.

@dcousineau-godaddy
Copy link

@jpage-godaddy I think the branch protection rules are configured incorrectly, it's waiting for a job that doesn't exist.

@dcousineau-godaddy
Copy link

@jpage-godaddy I updated the branch protection rules to require teh build 12 and 14 jobs to complete

@jpage-godaddy jpage-godaddy merged commit 25164d1 into main Jun 24, 2022
@jpage-godaddy jpage-godaddy deleted the purge-artifactory-refs branch June 24, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msluther msluther msluther approved these changes

@dcousineau-godaddy dcousineau-godaddy dcousineau-godaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove private npm registry from lock files
3 participants
@jpage-godaddy @dcousineau-godaddy @msluther