Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds TypeScript flavor packages for ESLint #89

Merged
merged 6 commits into from
Jan 24, 2020
Merged

Adds TypeScript flavor packages for ESLint #89

merged 6 commits into from
Jan 24, 2020

Conversation

andyfleming
Copy link
Contributor

No description provided.

fabiomcosta
fabiomcosta reviewed Jan 10, 2020
View reviewed changes
README.md Show resolved Hide resolved
@fabiomcosta
Copy link
Contributor

#88 has been merged, so I would adjust this PR to have less peerDeps, according to what has been done there.
This looks fantastic!

indexzero
indexzero approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable – thanks for adding this. Might be worth considering a move to lerna now that we have enough packages, but that's not blocking of course.

@DullReferenceException DullReferenceException merged commit 48f0652 into godaddy:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiomcosta fabiomcosta fabiomcosta left review comments

@indexzero indexzero indexzero approved these changes

@DullReferenceException DullReferenceException DullReferenceException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyfleming @fabiomcosta @indexzero @DullReferenceException