Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of 'Sender' and 'Destination' for Sending and Receiving #326

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kkoehler
Copy link

Hi,

we need to receive the DBus Sender of a message and we also want to pass the Destination header along with a message. Therefor we enhanced the dbus.Method interface to include another param of type "dbus.Sender" which will automatically set if the client impl has such a param. On the other hand we introduced a new type "dbus.Destination" which can be passed to Emit calls...

Kristian

@guelfey
Copy link
Member

guelfey commented Jun 6, 2022

I'm fine with adding something like EmitWithDestination, but I'm against the changes to method calling since it's a breaking change on the public API of this package. You should be able to achieve the same using https://pkg.go.dev/github.com/godbus/dbus/v5#WithIncomingInterceptor if really needed. (Also, please ensure that the linting passes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants