Re-enable ThemeDb + impl GodotConvert for *mut c_void
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-461 |
Bromeon
reviewed
Oct 24, 2023
godot-codegen/src/util.rs
Outdated
Comment on lines
206
to
210
| if cfg!(before_api = "4.2") && class.name == "ThemeDB" { | ||
| // registered in C++ register_scene_singletons(), after MODULE_INITIALIZATION_LEVEL_EDITOR happens. | ||
| // fixed since 4.2 (https://github.com/godotengine/godot/pull/81305) | ||
| ClassCodegenLevel::Lazy | ||
| } else if class.name.ends_with("Server") { |
There was a problem hiding this comment.
I wonder if this is still necessary now...
- before 4.2,
ThemeDBclass is absent -> so the API level shouldn't be queried - since 4.2,
ThemeDBhasScenelevel
Could you try to entirely remove this branch, as well as the ClassCodegenLevel::Lazy variant?
There was a problem hiding this comment.
you're right, I was able to remove it without a problem 👍
| @@ -240,3 +240,21 @@ impl FromGodot for *const std::ffi::c_void { | |||
| Some(via as Self) | |||
| } | |||
| } | |||
|
|
|||
| // mut void* is used by ScriptExtension::instance_create() | |||
There was a problem hiding this comment.
In C, it's just void*, not mut void*.
You could move this up to line 226, before // Other impls..., then it should be clearer.
Also please end with a full stop 🙂
Bromeon
added
quality-of-life
Bromeon
changed the title
ThemeDb + impl GodotConvert for *mut c_void
aekobear
force-pushed
the
mut-cvoid-and-themedb
branch
from
c5d5350 to
4650b82
Compare
|
Thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThemeDB has been fixed (Fix ThemeDB initialization in tests godotengine/godot#81305) and is instantiated before Editor level, so we can now reenable it
*mut c_void is needed for the
instance_createsignature of Godot'sScriptExtensionclass, so I added the impls for it